Update bloom.go #437
Open
Update bloom.go #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
用法过时了，已更新
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+11
to
+14
| //store := redis.New("192.168.8.6:6379") //过时的 | ||
| redconf := redis.RedisConf{Host: "192.168.8.6:6379", | ||
| Pass: "redis_6X6RSk", Type: "node"} | ||
| store := redis.MustNewRedis(redconf) |
There was a problem hiding this comment.
logic: Hardcoding Redis credentials in the source code is a security risk. Consider using environment variables or a configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用法过时了，已更新
Greptile Summary
This PR updates the Redis connection setup in the bloom filter example, addressing a deprecated function usage but introducing potential security concerns.
redis.New()withredis.MustNewRedis()inbloom/bloom.goRedisConfstruct with hardcoded Redis host, password, and node type